Move IVTs from AssemblyInfo into project files #10573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwengier
approved these changes
Jul 2, 2024
chsienki
approved these changes
Jul 2, 2024
...t.AspNetCore.Mvc.Razor.Extensions/test/Microsoft.AspNetCore.Mvc.Razor.Extensions.Test.csproj
Outdated
Show resolved
Hide resolved
...piler/Microsoft.CodeAnalysis.Razor.Compiler/src/Microsoft.CodeAnalysis.Razor.Compiler.csproj
Outdated
Show resolved
Hide resolved
jjonescz
reviewed
Jul 3, 2024
| <!-- RestrictedInternalsVisibleTo --> | ||
| <ItemDefinitionGroup> | ||
| <RestrictedInternalsVisibleTo> | ||
| <Visible>false</Visible> |
There was a problem hiding this comment.
It probably doesn't have much impact, but it matches the item definition for InternalsVisibleTo in arcade:
jjonescz
approved these changes
Jul 3, 2024
This was referenced Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been meaning to do this for a long while now. This change removes all of the IVTs from
AssemblyInfo.csfiles and places them in the relevant project file. I've also added a target to processRestrictedInternalsVisibleTo, though that's only used by MS.ANC.Razor.LanguageServer to restrict the IVT to the "Microsoft.AspNetCore.Razor.LanguageServer.Hosting" namespace.